[Fixed] Change talents error

[Shestak]

Try this fix https://github.com/Shestak/ShestakUI...6e4b9142ee2c83

GitHub latest version https://github.com/Shestak/ShestakUI/archive/master.zip

[Puree]

Works great, thank you

[Lamindra]

You have fixed the unfixable! No /rl - everything works. Cheers to you guys

Now you can change the "Never fixed" to "Finally fixed"

Edit: WoW trolls me. Worked for about 10 talent switches, then the same error occured, after five /rl nothing happened and on the sixth /rl everything was fine? Is that normal? :s

[Shestak]

Originally Posted by Lamindra

Is that normal?

In Basically yes.
*Temporarily.

[Lamindra]

Just seems to be so random, but okay. Thanks.

Posted in 16 minute
I found a way to reproduce the error. After a /rl everything works fine, until you get a message vom Battle.net (e.g. a battle.net wisper, or even when somebody comes online on battle.net). I really don't know, why this happens, but it works perfect, until a message from battle.net happens. Hopefully this helps you.

[Shestak]

Only bnet whisper? What about inrealm whisper?

[Lamindra]

Also inrealm wisper! But it only occurs on Bnet wisper/Bnet "someone comes online"/inrealm wisper.

Edit: It also only occurs, when you recieve a message, so when you are whispering someone else everything is fine.

[Fugaru]

I'm using version 4.45 without the IsDisabledByParentalControls fix in Modules\Blizzard\Fixes.lua

I'm getting all the errors on achievement and map toggles but atleast I can change talents and glyphs. I only pvp and not able to change talents or glyphs in arena is just not an option.

I've also tried the latest github version but I'm unable to change talents or glyphs. These are the errors I'm grabbing:

When changing talents:

1x [ADDON_ACTION_FORBIDDEN] AddOn "ShestakUI" tried to call the protected function "RemoveTalent()".
!BugGrabber-r198-release\BugGrabber.lua:552: in function <!BugGrabber\BugGrabber.lua:552>
<in C code>
Blizzard_TalentUI\Blizzard_TalentUI.lua:39: in function "OnAccept"
FrameXML\StaticPopup.lua:3832: in function "StaticPopup_OnClick"
<string>:"*:OnClick":1: in function <string>:"*:OnClick":1

Locals:
nil

1x Blizzard_TalentUI\Blizzard_TalentUI.lua:710: attempt to perform arithmetic on local "id" (a nil value)
Blizzard_TalentUI\Blizzard_TalentUI.lua:710: in function "PlayerTalentFrame_SelectTalent"
Blizzard_TalentUI\Blizzard_TalentUI.lua:40: in function "OnAccept"
FrameXML\StaticPopup.lua:3832: in function "StaticPopup_OnClick"
<string>:"*:OnClick":1: in function <string>:"*:OnClick":1

Locals:
self = StaticPopup1 {
 0 = <userdata>
 hideOnEscape = 1
 itemFrame = StaticPopup1ItemFrame {
 }
 data = "ShestakUI"
 button3 = StaticPopup1Button3 {
 }
 extraFrame = StaticPopup1ExtraFrame {
 }
 icon = StaticPopup1AlertIcon {
 }
 maxWidthSoFar = 320
 oborder = StaticPopup1OuterBorder {
 }
 moneyFrame = StaticPopup1MoneyFrame {
 }
 moneyInputFrame = StaticPopup1MoneyInputFrame {
 }
 text = StaticPopup1Text {
 }
 numButtons = 1
 editBox = StaticPopup1EditBox {
 }
 timeleft = 0
 iborder = StaticPopup1InnerBorder {
 }
 exclusive = 1
 button2 = StaticPopup1Button2 {
 }
 maxHeightSoFar = 100.00005149841
 button1 = StaticPopup1Button1 {
 }
 which = "ADDON_ACTION_FORBIDDEN"
}
talentGroup = 2

When changing Glyphs:

1x [ADDON_ACTION_FORBIDDEN] AddOn "ShestakUI" tried to call the protected function "CastGlyph()".
!BugGrabber-r198-release\BugGrabber.lua:552: in function <!BugGrabber\BugGrabber.lua:552>
<in C code>
Blizzard_GlyphUI\Blizzard_GlyphUI-1.0.lua:525: in function "GlyphFrameSpell_OnClick"
<string>:"*:OnClick":1: in function <string>:"*:OnClick":1

Locals:
nil

[Shestak]

Originally Posted by Fugaru

I'm using version 4.45

Update UI version and test without other addons.

[Lamindra]

So should the last commit "Cleanup" fix the chat error?